Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow read files in discharged consultations #1204

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Conversation

khavinshankar
Copy link
Member

Proposed Changes

  • Allow read files in discharged consultations

Associated Issue

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@khavinshankar khavinshankar requested a review from a team as a code owner February 25, 2023 10:01
@sonarcloud
Copy link

sonarcloud bot commented Feb 25, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell D 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Base: 56.20% // Head: 56.20% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (0865e52) compared to base (3105155).
Patch coverage: 33.33% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1204      +/-   ##
==========================================
- Coverage   56.20%   56.20%   -0.01%     
==========================================
  Files         174      174              
  Lines        8812     8813       +1     
  Branches     1521     1522       +1     
==========================================
  Hits         4953     4953              
- Misses       3805     3806       +1     
  Partials       54       54              
Impacted Files Coverage Δ
care/facility/api/viewsets/file_upload.py 50.00% <ø> (ø)
care/facility/api/serializers/file_upload.py 41.93% <33.33%> (-0.35%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@vigneshhari vigneshhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to club the if's together without making a chain

@vigneshhari vigneshhari merged commit 460ef7c into master Mar 9, 2023
Ashesh3 pushed a commit to Ashesh3/care that referenced this pull request Mar 22, 2023
allow read files in discharged consultations
@sainak sainak deleted the fix#1203 branch June 6, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permission denied error when patient is discharged and files tab is opened
3 participants