Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Review Interval in Patient Consultation for Daily Round Entries #1215

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Mar 12, 2023

Fixes coronasafe/care_fe#5086

This pull request addresses an issue where the frontend was not displaying the review badge despite the presence of review_time. The proposed solution involves ensuring that the review_interval is included when review_time is set. Specifically, the PR updates the daily round entries to save the selected review_interval to the patient consultation, which should resolve the issue and allow the review badge to be displayed correctly in the frontend.

@coronasafe/code-reviewers

@Ashesh3 Ashesh3 requested a review from a team as a code owner March 12, 2023 06:50
@sonarcloud
Copy link

sonarcloud bot commented Mar 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 7.69% and project coverage change: -0.02 ⚠️

Comparison is base (2a7c6f7) 56.12% compared to head (c680036) 56.11%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1215      +/-   ##
==========================================
- Coverage   56.12%   56.11%   -0.02%     
==========================================
  Files         174      174              
  Lines        8826     8829       +3     
  Branches     1525     1525              
==========================================
  Hits         4954     4954              
- Misses       3818     3821       +3     
  Partials       54       54              
Impacted Files Coverage Δ
care/facility/api/serializers/daily_round.py 33.77% <7.69%> (-0.69%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nihal467 nihal467 added the P2 label Mar 12, 2023
@gigincg gigincg merged commit ff4415f into coronasafe:master Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review time is malfunctioning in patient log update
5 participants