Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables API docs in production #1225

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Conversation

rithviknishad
Copy link
Member

Proposed Changes

  • Disables API docs if settings.IS_PRODUCTION
  • isort pre-commit hook doing its thing

Associated Issue

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@rithviknishad rithviknishad requested a review from a team as a code owner March 21, 2023 10:04
@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.01 ⚠️

Comparison is base (b3839b5) 56.22% compared to head (67c6e9c) 56.22%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1225      +/-   ##
==========================================
- Coverage   56.22%   56.22%   -0.01%     
==========================================
  Files         193      193              
  Lines        9489     9491       +2     
  Branches     1599     1600       +1     
==========================================
+ Hits         5335     5336       +1     
  Misses       4100     4100              
- Partials       54       55       +1     
Impacted Files Coverage Δ
config/urls.py 77.77% <66.66%> (-2.23%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vigneshhari
Copy link
Member

Thanks @rithviknishad

@vigneshhari vigneshhari merged commit 5da2c52 into master Mar 21, 2023
@sainak sainak deleted the disable-api-docs-in-prod branch June 6, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable API Docs in production
3 participants