Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter skills by userskill__deleted=False in UserAssignedSerializer #1251

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

rithviknishad
Copy link
Member

Proposed Changes

  • Filter skills by userskill__deleted=False in UserAssignedSerializer

Associated Issue

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@rithviknishad rithviknishad requested a review from a team as a code owner April 14, 2023 10:54
@rithviknishad rithviknishad changed the title fixes coronasafe/care_fe#5336 Filter skills by userskill__deleted=False in UserAssignedSerializer Apr 14, 2023
@rithviknishad rithviknishad added P1 High priority; urgent waiting-for-review labels Apr 14, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01 ⚠️

Comparison is base (c1c952f) 56.19% compared to head (ae283d8) 56.19%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1251      +/-   ##
==========================================
- Coverage   56.19%   56.19%   -0.01%     
==========================================
  Files         193      193              
  Lines        9527     9530       +3     
  Branches     1609     1609              
==========================================
+ Hits         5354     5355       +1     
- Misses       4118     4120       +2     
  Partials       55       55              
Impacted Files Coverage Δ
care/users/api/serializers/user.py 58.97% <50.00%> (-0.51%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gigincg gigincg merged commit 8a38c50 into master Apr 14, 2023
@sainak sainak deleted the user-assigned-serializer-filter-skills branch June 6, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority; urgent waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doctor connect is showing unlink skills of users
3 participants