Centralise linting across project #1258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
|
The pipelines are still failing @rithviknishad |
|
@vigneshhari those are flake8 lints. it'll require manually modifying the code. There's like 150 such modifications required :)
|
|
@rithviknishad we need to fix those as well 😓 otherwise we can't use the pipeline to ensure that the code is in the right format all the time |
|
Move Exception to BaseException and remove unused variables/imports/unused f strings. I will fix the rest of them. |
|
Closing this PR as I am not able to push the changes on this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
black .andisort .Associated Issue
@coronasafe/code-reviewers
Merge Checklist
/docs