Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NONE to patient action #1262

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Add NONE to patient action #1262

merged 1 commit into from
Apr 27, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Apr 19, 2023 •
edited
Loading

Required for coronasafe/care_fe#5342
Frontend PR: coronasafe/care_fe#5355

  • Adds a None option to patient action.
  • Migrate all existing "Pending" action to "None"
  • Set the default action value to None

@coronasafe/code-reviewers

@Ashesh3 Ashesh3 requested a review from a team as a code owner April 19, 2023 06:39
@Ashesh3 Ashesh3 mentioned this pull request Apr 19, 2023
Merged
4 tasks
@nihal467 nihal467 added the P1 High priority; urgent label Apr 19, 2023
siddnikh
siddnikh approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@siddnikh siddnikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ashesh3 Ashesh3 added In progress Work in progress and removed waiting-for-review labels Apr 24, 2023
@Ashesh3 Ashesh3 added waiting-for-review and removed In progress Work in progress labels Apr 24, 2023
@Ashesh3 Ashesh3 requested a review from gigincg April 24, 2023 06:58
@sonarcloud
Copy link

sonarcloud bot commented Apr 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@vigneshhari vigneshhari merged commit bd5c428 into coronasafe:master Apr 27, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshhari vigneshhari vigneshhari approved these changes

@siddnikh siddnikh siddnikh approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
P1 High priority; urgent waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ashesh3 @gigincg @vigneshhari @siddnikh @nihal467