-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "None" to patient action #5355
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
LGTM |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
khavinshankar
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #5348 . That needs to be merged before merging this PR.
Backend PR: ohcnetwork/care#1262
WHAT
🤖 Generated by Copilot at 2b7de19
This pull request improves the daily rounds and consultation forms for patients by adding and displaying more information about their actions and categories. It also refactors and renames some fields and constants for clarity and consistency. The main files affected are
DailyRounds.tsx
,constants.tsx
, andConsultationForm.tsx
.Proposed Changes
Fixes Action in log update is malfunctioning #5342
action field should be optional
default should be a null
pending should be having a reflection in the patient list
migrate all existing data having pending action in the system to null
TODO: pending should be having a reflection in the patient list (Need to discuss how exactly to show this)
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
HOW
🤖 Generated by Copilot at 2b7de19
ICMR_CATEGORY
andTELEMEDICINE_ACTIONS
constants, which are used to display and select the ICMR category and the action recommended for a patient in the consultation form (link, link)actions
field toaction
in theinitForm
constant for the daily rounds form, to match the field name in the consultation form and the backend API (link)DailyRounds
component, using anonymous async functions insideuseEffect
hooks (link, link)SelectField
component and the setter functions (link, link)data
object (link)