Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump isort as pre-commit initialize fails with older version #1289

Merged
merged 3 commits into from
May 7, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented May 7, 2023

Proposed Changes

  • Bump isort as pre-commit initialize fails with older version of isort.
    image

Associated Issue

Architecture changes

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@rithviknishad rithviknishad requested a review from a team as a code owner May 7, 2023 02:19
@rithviknishad rithviknishad changed the title bump isort bump isort as pre-commit initialize fails with older version May 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2ef9aea) 56.18% compared to head (3fedb62) 56.18%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1289   +/-   ##
=======================================
  Coverage   56.18%   56.18%           
=======================================
  Files         195      195           
  Lines        9625     9625           
  Branches     1615     1615           
=======================================
  Hits         5408     5408           
  Misses       4162     4162           
  Partials       55       55           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
requirements/local.txt Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented May 7, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@vigneshhari vigneshhari merged commit 17632aa into master May 7, 2023
@sainak sainak deleted the bump-isort branch June 6, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants