Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: use docker compose instead of docker-compose #1293

Merged
merged 1 commit into from
May 13, 2023

Conversation

rithviknishad
Copy link
Member

Proposed Changes

  • Use docker compose instead of docker-compose in Makefile as compose command is now part of docker CLI itself in newer versions.

Associated Issue

Architecture changes

  • none

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@rithviknishad rithviknishad requested a review from a team as a code owner May 9, 2023 16:47
@sonarcloud
Copy link

sonarcloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (cd15b6e) 56.18% compared to head (f043141) 56.18%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1293   +/-   ##
=======================================
  Coverage   56.18%   56.18%           
=======================================
  Files         195      195           
  Lines        9625     9625           
  Branches     1615     1615           
=======================================
  Hits         5408     5408           
  Misses       4162     4162           
  Partials       55       55           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vigneshhari vigneshhari merged commit 89e3be4 into master May 13, 2023
6 checks passed
@sainak sainak deleted the makefile-docker-compose branch June 6, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Makefile: use docker compose instead of docker-compose since compose command is now part of docker cli itself
3 participants