Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't update last daily round if round is automated #1301

Merged
merged 1 commit into from
May 19, 2023
Merged

don't update last daily round if round is automated #1301

merged 1 commit into from
May 19, 2023

Conversation

sainak
Copy link
Member

@sainak sainak commented May 18, 2023

Proposed Changes

  • skip update_last_daily_round if the round type is automated

Associated Issue

Architecture changes

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@sainak sainak requested a review from a team as a code owner May 18, 2023 11:18
@sonarcloud
Copy link

sonarcloud bot commented May 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vigneshhari vigneshhari merged commit 63394bc into master May 19, 2023
6 checks passed
@khavinshankar khavinshankar deleted the sainak/fix-1300 branch May 19, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshhari vigneshhari vigneshhari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automated daily round should not update last daily round in consultation
2 participants
@sainak @vigneshhari