Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all instances of orgin_facility to origin_facility #1303

Merged
merged 4 commits into from
Jun 26, 2023

Conversation

sainak
Copy link
Member

@sainak sainak commented May 19, 2023

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@sainak sainak requested a review from a team as a code owner May 19, 2023 09:07
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

Patch coverage: 33.33% and no project coverage change.

Comparison is base (e5e7453) 56.66% compared to head (960ee9e) 56.66%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1303   +/-   ##
=======================================
  Coverage   56.66%   56.66%           
=======================================
  Files         195      195           
  Lines        9862     9862           
  Branches     1655     1655           
=======================================
  Hits         5588     5588           
  Misses       4220     4220           
  Partials       54       54           
Impacted Files Coverage Δ
care/utils/queryset/shifting.py 20.00% <0.00%> (ø)
care/facility/api/viewsets/resources.py 55.33% <16.66%> (ø)
care/facility/api/serializers/resources.py 47.36% <33.33%> (ø)
care/facility/api/viewsets/shifting.py 58.62% <33.33%> (ø)
care/facility/api/serializers/shifting.py 43.27% <50.00%> (ø)
care/facility/models/resources.py 76.36% <100.00%> (ø)
care/facility/models/shifting.py 78.33% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented May 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vigneshhari
Copy link
Member

vigneshhari commented Jun 13, 2023

@sainak

  • can you link the corresponding FE PR as well, since the API contract changes we would need to merge the FE PR as well.
  • I have updated with the base branch, merge the migrations

@sainak
Copy link
Member Author

sainak commented Jun 24, 2023

@vigneshhari i've updated the migrations

@vigneshhari vigneshhari merged commit 23da6aa into master Jun 26, 2023
5 checks passed
@vigneshhari vigneshhari deleted the sainak/issue1279 branch June 26, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename all instances of orgin_facility to origin_facility
3 participants