-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix prescriptions migration #1305
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #1305 +/- ##
==========================================
- Coverage 56.72% 56.72% -0.01%
==========================================
Files 198 198
Lines 9840 9841 +1
Branches 1640 1641 +1
==========================================
Hits 5582 5582
- Misses 4203 4204 +1
Partials 55 55
☔ View full report in Codecov by Sentry. |
SonarCloud Quality Gate failed.
|
* nullable dosage, re-order and adds missing fileupload migration * clean prescriptions data when migrating * skip if medicine is none * nullable prescribed_by and set default for notes * increase medicine max_length to 256 * round off min_hours_between_doses * increase medicine max_length to 1023 * round off days * clean int: return None if empty string or other exceptions * squash migrations * merge migrations
Proposed Changes
medicine
field: Increased length to 1023 (failed with 100 and 255).prescribed_by
field: setnull=True
asconsultation.created_by
is alsonull=True
.Tested Migrations with a staging duplicate DB
@coronasafe/code-reviewers
Merge Checklist
/docs