Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use consistent phone number validation #1308

Closed
wants to merge 1 commit into from
Closed

Conversation

sainak
Copy link
Member

@sainak sainak commented May 23, 2023

Proposed Changes

  • use regex validator everywhere
  • remove phone number field

Associated Issue

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@sainak sainak requested a review from a team as a code owner May 23, 2023 10:45
@sainak sainak closed this May 25, 2023
@sainak sainak deleted the sainak/issue1243 branch May 25, 2023 11:06
@sainak sainak restored the sainak/issue1243 branch May 25, 2023 11:06
@sainak sainak reopened this May 25, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.09 ⚠️

Comparison is base (831c216) 56.66% compared to head (a7c6d8c) 56.57%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1308      +/-   ##
==========================================
- Coverage   56.66%   56.57%   -0.09%     
==========================================
  Files         195      194       -1     
  Lines        9861     9836      -25     
  Branches     1655     1651       -4     
==========================================
- Hits         5588     5565      -23     
+ Misses       4219     4218       -1     
+ Partials       54       53       -1     
Impacted Files Coverage Δ
care/facility/api/serializers/patient.py 55.94% <ø> (-0.58%) ⬇️
care/facility/api/serializers/shifting.py 42.60% <ø> (-0.68%) ⬇️
care/users/api/serializers/user.py 57.89% <ø> (-1.08%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sainak sainak closed this Jun 20, 2023
@sainak sainak deleted the sainak/issue1243 branch June 24, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing proper validation for phone number in patient registration form
2 participants