Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a check on is_occupied for bed delete action #1312

Merged
merged 1 commit into from
May 25, 2023

Conversation

rithviknishad
Copy link
Member

Proposed Changes

image

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@rithviknishad rithviknishad requested a review from a team as a code owner May 24, 2023 12:13
@rithviknishad rithviknishad added waiting-for-review P1 High priority; urgent labels May 24, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (a7b46d2) 56.72% compared to head (956461d) 56.70%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1312      +/-   ##
==========================================
- Coverage   56.72%   56.70%   -0.02%     
==========================================
  Files         199      199              
  Lines        9863     9866       +3     
  Branches     1645     1646       +1     
==========================================
  Hits         5595     5595              
- Misses       4213     4216       +3     
  Partials       55       55              
Impacted Files Coverage Δ
care/facility/api/viewsets/bed.py 55.31% <0.00%> (-1.83%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vigneshhari vigneshhari merged commit 330ff75 into master May 25, 2023
6 checks passed
yaswanthsaivendra pushed a commit to yaswanthsaivendra/care that referenced this pull request May 30, 2023
@sainak sainak deleted the prevent-occupied-bed-delete branch June 6, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority; urgent waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow deletion of bed if occupied
3 participants