Create ConsultationBed only on if Admission and migrates existing non-admission ConsultationBeds.
#1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #1314 +/- ##
=======================================
Coverage 56.72% 56.72%
=======================================
Files 199 199
Lines 9863 9863
Branches 1645 1645
=======================================
Hits 5595 5595
Misses 4213 4213
Partials 55 55
☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
LGTM after testing it in @rithviknishad tunnel |
vigneshhari
approved these changes
May 25, 2023
yaswanthsaivendra
pushed a commit
to yaswanthsaivendra/care
that referenced
this pull request
May 30, 2023
…on-admission `ConsultationBed`s. (coronasafe#1314) * create consultation bed only on admission * migratees existing non-admission consultation beds * optimize query * delete after update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
ConsultationBedonly if the decision after consultation is "Admission"ConsultationBeds to haveend_dateequal todischarge_date(since its soft delete) and soft deletes it too.Before Migration
After Migration
Associated Issue
Architecture changes
@coronasafe/code-reviewers
Merge Checklist
/docs