implementing manual logic of on_delete option in M2M models

[yaswanthsaivendra]

Proposed Changes

• Implementing on_delete logic in below M2M models as it doesnt work coz of our soft delete logic.

• UserDefaultAssetLocation ( Implements soft delete logic on - AsseLocation , User )

• FacilityDefaultAssetLocation ( Implements soft delete logic on - AssetLocation, Facility )

• ConsultationBed ( Implements soft delete logic on - Bed, PatientConsultation )

• FacilityUser ( Implements soft delete logic on - Facility , user, created_by )

• InvestigationValue ( Implements soft delete logic on - PatientConsultation, PatientInvestigationGroup, PatientInvestigation, InvestigationSession )

• PatientSample ( Implements soft delete logic on - PatientRegistration, PatientConsulation and set NULL to created_by, last_edited_by of User Model , Facility )

• For relations having models.CASCADE and models.PROTECT - I implemented soft delete logic

• For relations having models.SET_NULL - I set them to NULL

Associated Issue

• Fixes Manually cascade delete M2M models when related model is deleted. #1330

@coronasafe/code-reviewers

[yaswanthsaivendra]

@rithviknishad Review please!

[rithviknishad]

You are performing <QuerySet>.delete(). However, we've overridden the <Instance>.delete() to soft delete only.
Would <QuerySet>.delete() call the overridden delete method and soft delete or does it hard delete?

[rithviknishad]

@yaswanthsaivendra also could you prefix the issue numbers with "Fixes" or other linking keywords?

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

[yaswanthsaivendra]

You are performing <QuerySet>.delete(). However, we've overridden the <Instance>.delete() to soft delete only. Would <QuerySet>.delete() call the overridden delete method and soft delete or does it hard delete?

🤦😅 hard delete, made changes to soft delete

[yaswanthsaivendra]

@yaswanthsaivendra also could you prefix the issue numbers with "Fixes" or other linking keywords?

My bad, I did all changes in single commit 😮‍💨. Referenced the changes in each task. Please check it now!
ohh okay, Got it. Made that change in all my open PRs

[yaswanthsaivendra]

@sainak Please review this

[vigneshhari]

@sainak Can you review?