Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Regex Validator for Phone Number Field for Patient Registration Form #1406

Merged
merged 11 commits into from
Jun 25, 2023

Conversation

siddnikh
Copy link
Contributor

Solves #1405
The landline numbers weren't getting accepted because the regex expected one of 4,5,6,7,8 or 9 after 0 in the starting of the phone number.
This won't work because most of the std codes start with 1 or 2 or 3.

@vigneshhari vigneshhari requested a review from sainak June 25, 2023 10:08
@vigneshhari
Copy link
Member

@sainak I am merging this MR, could you create an issue to add some tests for this change? ( or you can do it yourself! )

@vigneshhari vigneshhari merged commit 23821c5 into coronasafe:master Jun 25, 2023
2 checks passed
@sainak sainak mentioned this pull request Jun 25, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants