Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medibase: Drop littletable; instead store as list from ORM's values_list #1443

Merged
merged 8 commits into from
Jul 11, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jul 7, 2023

Proposed Changes

  • MedibaseMedicineTable no longer uses littletable and is now simply a list fetched ORM's values_list

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@rithviknishad rithviknishad changed the title Medibase: Drop littletable; store in records in variable Medibase: Drop littletable; store records in variable Jul 7, 2023
@rithviknishad rithviknishad changed the title Medibase: Drop littletable; store records in variable Medibase: Drop littletable; instead store as tuple[tuple] Jul 8, 2023
@rithviknishad rithviknishad marked this pull request as ready for review July 8, 2023 06:12
@nihal467
Copy link
Member

I tested in tunnel provided by @rithviknishad's and added multiple medicines to a patients looks good to me in a general view

@rithviknishad rithviknishad added the P1 High priority; urgent label Jul 10, 2023
@rithviknishad
Copy link
Member Author

rithviknishad commented Jul 10, 2023

Gunicorn Worker timeout occurs as loading to in-memory on wsgi.py takes too much time for (0.25cpu)
No memory issues though.

@rithviknishad
Copy link
Member Author

rithviknishad commented Jul 10, 2023

But this happens for me even with lazy load (load on first search request instead of on wsgi.py) on my CPU.
Probably because my 0.25 cpu is not same as staging instances 0.25 cpu

Same happens for me in master branch on my local too with 0.25 cpu; but works in staging.

@rithviknishad rithviknishad changed the title Medibase: Drop littletable; instead store as tuple[tuple] Medibase: Drop littletable; instead store as list from ORM's values_list Jul 10, 2023
Co-authored-by: Aakash Singh <mail@singhaakash.dev>
@vigneshhari vigneshhari merged commit eb98ba0 into master Jul 11, 2023
2 checks passed
@vigneshhari vigneshhari deleted the medibase-custom-inmem-search branch July 11, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority; urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants