Don't allow negative values for Doctor Count for facility #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sainak
requested changes
Aug 3, 2023
Done! |
yes migrations will be required |
|
@Pranshu1902 rebase and then make migrations |
|
Added migrations @sainak @rithviknishad |
sainak
reviewed
Aug 4, 2023
care/facility/migrations/0375_alter_dailyround_resp_alter_hospitaldoctors_count.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Aakash Singh <mail@singhaakash.dev>
@Pranshu1902 make sure to handle negative values while migrating |
|
@vigneshhari @sainak updated! |
sainak
approved these changes
Aug 18, 2023
|
@sainak @vigneshhari please review and merge the PR |
|
@Pranshu1902 delete and recreate the migrations |
|
@sainak done |
|
@vigneshhari please review and merge the PR |
vigneshhari
approved these changes
Dec 7, 2023
sainak
added a commit
that referenced
this pull request
Dec 7, 2023
vigneshhari
pushed a commit
that referenced
this pull request
Dec 7, 2023
* merge migrations * fix bad migration from #1505 * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Raise Validation error when user tries to give a negative value for the doctor count for a facility.
Associated Issue
#1504
Merge Checklist
/docsOnly PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins