Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds pre-commit hook and CI step in test to ensure no migrations are missing #1509

Merged
merged 4 commits into from
Aug 4, 2023
Merged

Adds pre-commit hook and CI step in test to ensure no migrations are missing #1509

merged 4 commits into from
Aug 4, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Aug 3, 2023 •
edited
Loading

Proposed Changes

  • Added pre-commit hook to ensure no migrations are missing
  • Added missing migration check in Test CI

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@rithviknishad rithviknishad changed the title Adds pre-commit hook to ensure no migrations are missing Adds pre-commit hook and CI step in test to ensure no migrations are missing Aug 4, 2023
@rithviknishad
Copy link
Member Author

Tests CI should pass once #1501 is merged.

@rithviknishad rithviknishad self-assigned this Aug 4, 2023
@sainak
Copy link
Member

sainak commented Aug 4, 2023

Tests failing as expected

@vigneshhari
Copy link
Member

Testing if pipeline succeeds on no missing migrations

@vigneshhari vigneshhari merged commit e337654 into master Aug 4, 2023
2 checks passed
@vigneshhari vigneshhari deleted the adds-precommit-to-check-migrations branch August 4, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshhari vigneshhari vigneshhari approved these changes

@sainak sainak sainak approved these changes

@tomahawk-pilot tomahawk-pilot Awaiting requested review from tomahawk-pilot

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees

@rithviknishad rithviknishad

Labels
waiting-for-review
Projects
Care
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rithviknishad @sainak @vigneshhari