Check bed name before making new multiple beds with same name #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sainak
reviewed
Aug 22, 2023
Comment on lines
+69
to
+77
| start = 1 | ||
| while True: | ||
| if not Bed.objects.filter( | ||
| name=f"{serializer.validated_data['name']} {start}", | ||
| facility=serializer.validated_data['facility'], | ||
| location=serializer.validated_data["location"] | ||
| ).exists(): | ||
| break | ||
| start += 1 |
There was a problem hiding this comment.
you can achieve this with a single query, search and reverse sort by name
|
@sainak any update regarding whether this check is needed at all? |
|
The solution would be to index the bed names and before creating beds do a lookup of any existing beds with names but creating unique index can cause conflict, so this is a blocker @vigneshhari what are your thoughts? |
|
Resolved in #1783 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
1behind each bed name, we first check the number from which the bed names are available and then start adding the beds. For example if the user is adding 2 beds with nameBedand there is already a bed with nameBed 1, then the new beds created will beBed 2&Bed 3instead ofBed 1&Bed 2.Associated Issue
Fixes #1529
Merge Checklist
/docsOnly PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins