List detail serializer notification #1531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sainak please review |
|
@sainak fixed conflicts |
sainak
reviewed
Aug 29, 2023
sainak
requested changes
Aug 29, 2023
|
@sainak the changes are done please review it again |
…etail-serializer-notification
…etail-serializer-notification
…com/geekgawd/care into list-detail-serializer-notification
sainak
reviewed
Sep 28, 2023
|
|
||
| @classmethod | ||
| def create_notification(cls, intended_for=None, **kwargs): | ||
| users = User.objects.exclude(username=cls.user.username) |
There was a problem hiding this comment.
Avoid directly referring to cls.user as this can cause unexpected results instead pass the required filters as an argument
Comment on lines
+506
to
+509
| [choice[0] for choice in Notification.MediumChoices] | ||
| ) | ||
| event_type = random.choice( | ||
| [choice[0] for choice in Notification.EventTypeChoices] |
Comment on lines
+483
to
+500
|
|
||
| def create_patient_note( | ||
| self, patient=None, note="Patient is doing find", created_by=None, **kwargs | ||
| ): | ||
| data = { | ||
| "facility": patient.facility or self.facility, | ||
| "note": note, | ||
| } | ||
| data.update(kwargs) | ||
|
|
||
| patientId = patient.external_id | ||
|
|
||
| refresh_token = RefreshToken.for_user(created_by) | ||
| self.client.credentials( | ||
| HTTP_AUTHORIZATION=f"Bearer {refresh_token.access_token}" | ||
| ) | ||
|
|
||
| self.client.post(f"/api/v1/patient/{patientId}/notes/", data=data) |
There was a problem hiding this comment.
remove code not relevant to this pr
| }] |
sainak
reviewed
Sep 28, 2023
sainak
reviewed
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add List and Detail Serializer
Cover 100% of Notification viewset with test cases
Brief of changes made.
Associated Issue
Merge Checklist
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins