Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorts medicine name exact matches first #1557

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Sorts medicine name exact matches first #1557

merged 2 commits into from
Aug 25, 2023

Conversation

rithviknishad
Copy link
Member

Proposed Changes

  • Sort by medicine name exact match first before word match.
  • Increase limit to 30

Associated Issue

Architecture changes

  • Remove this section if not used

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@rithviknishad rithviknishad added the P1 High priority; urgent label Aug 25, 2023
@vigneshhari
Copy link
Member

set a hard limit on the page size

@vigneshhari vigneshhari merged commit df1244b into master Aug 25, 2023
5 checks passed
@vigneshhari vigneshhari deleted the medicines-sort-name-exact-match-first branch August 25, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@sainak sainak sainak approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
P1 High priority; urgent waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generic Medicine: Paracetamol is not sorted first upon search
4 participants
@rithviknishad @vigneshhari @Ashesh3 @sainak