Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup and refactor tests #1584

Merged
merged 1 commit into from
Sep 11, 2023
Merged

fix: cleanup and refactor tests #1584

merged 1 commit into from
Sep 11, 2023

Conversation

sainak
Copy link
Member

@sainak sainak commented Sep 8, 2023

Proposed Changes

  • remove testmixin
  • create objects only when required
  • use dummy cache backend for tests

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@sainak sainak changed the title refactor tests fix: cleanup and refactor tests Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: +10.12% 🎉

Comparison is base (40484cf) 48.49% compared to head (685a98a) 58.61%.

❗ Current head 685a98a differs from pull request most recent head 2cfecf1. Consider uploading reports for the commit 2cfecf1 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1584       +/-   ##
===========================================
+ Coverage   48.49%   58.61%   +10.12%     
===========================================
  Files         683      205      -478     
  Lines       14359    11068     -3291     
  Branches     2518     1566      -952     
===========================================
- Hits         6964     6488      -476     
+ Misses       7182     4375     -2807     
+ Partials      213      205        -8     

see 489 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sainak sainak force-pushed the sainak/fix/tests branch 2 times, most recently from 170c204 to 9440a01 Compare September 11, 2023 12:08
@vigneshhari vigneshhari merged commit c94f464 into master Sep 11, 2023
9 checks passed
@vigneshhari vigneshhari deleted the sainak/fix/tests branch September 11, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants