-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Production Release; Spetember Week 3 #1613
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* used prefetch_related method to optimize the query performed to fetch a many to many relationship * Revert "add direnv support (#1304)" This reverts commit f613661. * Revert "Revert "add direnv support (#1304)"" This reverts commit 7d410fd. * Revert "used prefetch_related method to optimize the query performed to fetch a many to many relationship" This reverts commit 8946d5f. * used prefetch where we are querying the skills using UserAssigned Serializer * made neccessary changes to filter for having admitted but no bed assigned * Revert "used prefetch where we are querying the skills using UserAssigned Serializer" This reverts commit 7000a38. * updated the view to handle none option for bed type * changed value 8 into None for None option * made use of Q function to write the filter * made use of in lookup * fix * added tests and minor fixes in code * updated the test to make use of testbase * minor refactor Signed-off-by: Aakash Singh <mail@singhaakash.dev> * add more tests Signed-off-by: Aakash Singh <mail@singhaakash.dev> * refactor --------- Signed-off-by: Aakash Singh <mail@singhaakash.dev> Co-authored-by: Rithvik Nishad <rithvik.nishad@egovernments.org> Co-authored-by: Aakash Singh <mail@singhaakash.dev> Co-authored-by: Vignesh Hari <vichuhari100@gmail.com>
* add field readmission + custom migration * rebase migration * fix rebase migration
* add table to track user facility allocation * fixed edge cases * update migration Signed-off-by: Aakash Singh <mail@singhaakash.dev> --------- Signed-off-by: Aakash Singh <mail@singhaakash.dev>
it refactor tests
* add devcontainer config Signed-off-by: Aakash Singh <mail@singhaakash.dev> * add devcontainer config Signed-off-by: Aakash Singh <mail@singhaakash.dev> * switch to pipenv * fix tests * remove test workflow restriction * fix concurrency issue * update deploy workflow * revert removed step --------- Signed-off-by: Aakash Singh <mail@singhaakash.dev>
fix conflicting bed logic
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## production #1613 +/- ##
===============================================
+ Coverage 48.49% 59.08% +10.58%
===============================================
Files 683 205 -478
Lines 14359 11144 -3215
Branches 2518 1587 -931
===============================================
- Hits 6964 6584 -380
+ Misses 7182 4360 -2822
+ Partials 213 200 -13
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.