Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for archiving medicine administrations #1630

Merged
merged 8 commits into from
Oct 16, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Sep 20, 2023

Proposed Changes

  • Adds read-only fields: archived_by and archived_on to Medicine Administration model
  • Adds boolean filter: archived to Medicine Administration viewset

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2829067) 59.11% compared to head (c0a2a30) 59.19%.

❗ Current head c0a2a30 differs from pull request most recent head bd72d7d. Consider uploading reports for the commit bd72d7d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1630      +/-   ##
==========================================
+ Coverage   59.11%   59.19%   +0.07%     
==========================================
  Files         207      207              
  Lines       11264    11283      +19     
  Branches     1599     1604       +5     
==========================================
+ Hits         6659     6679      +20     
+ Misses       4405     4403       -2     
- Partials      200      201       +1     
Files Coverage Δ
care/facility/api/serializers/prescription.py 83.01% <100.00%> (+0.32%) ⬆️
care/facility/models/prescription.py 89.65% <100.00%> (+0.24%) ⬆️
care/facility/api/viewsets/prescription.py 94.11% <87.50%> (+1.88%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nihal467
Copy link
Member

nihal467 commented Oct 4, 2023

LGTM tested through local

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants