Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added warranty filter to Assets #1635

Merged
merged 6 commits into from
Sep 26, 2023

Conversation

GokulramGHV
Copy link
Member

@GokulramGHV GokulramGHV commented Sep 25, 2023

Proposed Changes

Added DateFromToRangeFilter to the AssetFilter to filter assets by their warranty expiry date.

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3e4f6fc) 59.08% compared to head (7b0f77f) 59.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1635   +/-   ##
=======================================
  Coverage   59.08%   59.08%           
=======================================
  Files         205      205           
  Lines       11145    11146    +1     
  Branches     1587     1587           
=======================================
+ Hits         6585     6586    +1     
  Misses       4360     4360           
  Partials      200      200           
Files Coverage Δ
care/facility/api/viewsets/asset.py 69.72% <100.00%> (+0.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

care/facility/tests/test_asset_api.py Outdated Show resolved Hide resolved
@vigneshhari vigneshhari merged commit 8cdaeb6 into ohcnetwork:master Sep 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants