-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added warranty filter to Assets #1635
Merged
vigneshhari
merged 6 commits into
ohcnetwork:master
from
GokulramGHV:asset-warranty-filter
Sep 26, 2023
Merged
Added warranty filter to Assets #1635
vigneshhari
merged 6 commits into
ohcnetwork:master
from
GokulramGHV:asset-warranty-filter
Sep 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1635 +/- ##
=======================================
Coverage 59.08% 59.08%
=======================================
Files 205 205
Lines 11145 11146 +1
Branches 1587 1587
=======================================
+ Hits 6585 6586 +1
Misses 4360 4360
Partials 200 200
☔ View full report in Codecov by Sentry. |
Ashesh3
requested changes
Sep 25, 2023
Ashesh3
approved these changes
Sep 26, 2023
rithviknishad
approved these changes
Sep 26, 2023
sainak
approved these changes
Sep 26, 2023
vigneshhari
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Added
DateFromToRangeFilter
to the AssetFilter to filter assets by their warranty expiry date.Associated Issue
Merge Checklist
/docs
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins