Implement Middleware Override in AssetLocation #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashesh3
requested review from
vigneshhari,
rithviknishad,
khavinshankar and
sainak
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1642 +/- ##
==========================================
- Coverage 59.11% 59.09% -0.03%
==========================================
Files 207 207
Lines 11264 11278 +14
Branches 1599 1602 +3
==========================================
+ Hits 6659 6665 +6
- Misses 4405 4412 +7
- Partials 200 201 +1
☔ View full report in Codecov by Sentry. |
rithviknishad
approved these changes
Sep 26, 2023
sainak
approved these changes
Sep 26, 2023
sainak
reviewed
Sep 26, 2023
|
@Ashesh3 does the dummy data facility disappear after the middleware was fixed, which we discussed during the huddle |
Issue was with dummy data itself; PR is fine. Will make a new PR to fix the dummy data. No changes are needed on the PR. |
|
LGTM |
vigneshhari
approved these changes
Oct 16, 2023
| "middleware_hostname", | ||
| asset.current_location.facility.middleware_address, | ||
| hostname = ( | ||
| asset.meta.get( |
There was a problem hiding this comment.
Maybe move this to a common function in the future? too much clutter now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #6310, which identified the need for a middleware override feature in the location management page. This feature is crucial for integrating multiple ICUs, each running on different servers with various teleicu middleware, under a single facility on the care platform.
Previously, the lack of this feature necessitated the redundant duplication of facilities for middleware configuration and deployment on care. With the implementation of the middleware override feature, we can now efficiently manage multiple servers in a single facility with multiple ICUs.
The changes in this PR include:
This feature enhances the overall usability and efficiency of the care platform, especially for larger institutions like hospitals with multiple departments.
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins