Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Asset Model Export Formatting #1654

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Oct 3, 2023

This PR introduces minor changes to the formatting of asset export fields in the Asset model. The modifications aim to enhance readability and data comprehension.

Changes include:

  1. Renaming the status field from "Working Status" to "Status".
  2. Modifying the current_location field to current_location__name to reflect the "Current Location Name".
  3. Changing the is_working field from "Is Working" to "Working Status".
  4. Removal of the warranty_details field from the export.
  5. Addition of a lambda function to the CSV_MAKE_PRETTY dictionary for the is_working field to display "WORKING" or "NOT WORKING" based on the field's boolean value.

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@nihal467
Copy link
Member

nihal467 commented Oct 3, 2023

LGTM tested through tunnel

@gigincg gigincg merged commit 0a4a4c4 into master Oct 3, 2023
9 checks passed
@gigincg gigincg deleted the asset-export-tweaks branch October 3, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants