Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude external_id from resources serializers #1701

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

rithviknishad
Copy link
Member

Proposed Changes

  • Exclude external_id from resources serializers as a duplicate of the serialized id field.

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a232d7) 60.05% compared to head (8569641) 60.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1701   +/-   ##
=======================================
  Coverage   60.05%   60.05%           
=======================================
  Files         208      208           
  Lines       11325    11325           
  Branches     1607     1607           
=======================================
  Hits         6801     6801           
  Misses       4300     4300           
  Partials      224      224           
Files Coverage Δ
care/facility/api/serializers/resources.py 47.36% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari vigneshhari merged commit 942cfe5 into master Nov 8, 2023
11 checks passed
@vigneshhari vigneshhari deleted the rithviknishad/fix-1687 branch November 8, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request Response Includes Redundant external_id
4 participants