Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort "No Consultation Filed" patients to the top of Patient List page #1718

Merged
merged 11 commits into from
Apr 22, 2024

Conversation

GokulramGHV
Copy link
Member

Proposed Changes

  • sorted patients such that patients with no consultation are before patients with consultation

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 61.83%. Comparing base (51ce81e) to head (be11738).
Report is 52 commits behind head on develop.

❗ Current head be11738 differs from pull request most recent head bcb0fb2. Consider uploading reports for the commit bcb0fb2 to get more accurate results

Files Patch % Lines
care/facility/api/viewsets/patient.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1718      +/-   ##
===========================================
- Coverage    62.20%   61.83%   -0.37%     
===========================================
  Files          221      221              
  Lines        12204    12165      -39     
  Branches      1742     1736       -6     
===========================================
- Hits          7591     7522      -69     
- Misses        4305     4334      +29     
- Partials       308      309       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this approach work for consultations with readmissions?

@nihal467
Copy link
Member

@GokulramGHV it is not working properly for patient on readmission

CC: @rithviknishad

@nihal467
Copy link
Member

nihal467 commented Dec 27, 2023

@GokulramGHV can you fix the issue ASAP

@Ashesh3
Copy link
Member

Ashesh3 commented Dec 28, 2023

Here is the conditions when we show the "No consultation filed" badge:

(!patient.last_consultation || patient.last_consultation?.facility !== patient.facility ||
(patient.last_consultation?.discharge_date && patient.is_active))

@GokulramGHV
Copy link
Member Author

Here is the conditions when we show the "No consultation filed" badge:

(!patient.last_consultation || patient.last_consultation?.facility !== patient.facility ||
(patient.last_consultation?.discharge_date && patient.is_active))

@Ashesh3 Thanks!

@GokulramGHV
Copy link
Member Author

@nihal467 Can you check if it works for the readmissions? I've updated the sorting order.

@nihal467
Copy link
Member

nihal467 commented Jan 1, 2024

LGTM

@sainak sainak self-assigned this Feb 15, 2024
@sainak sainak requested review from Ashesh3 and removed request for Ashesh3 March 1, 2024 12:22
@vigneshhari
Copy link
Member

Resolve conflicts

@GokulramGHV GokulramGHV requested a review from a team as a code owner April 11, 2024 17:51
@vigneshhari vigneshhari merged commit 164351d into coronasafe:develop Apr 22, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants