Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename admission_date to encounter_date and clean column #1728

Merged
merged 22 commits into from
Dec 20, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Nov 27, 2023

Proposed Changes

  • Rename admission_date to encounter_date
  • Updated validations to allow encounter_date for all consultations
  • ⚠️ Custom migration: set encounter_date to created_date for existing consultations that are not admission/domiciliary care or encounter_date is null.
  • Alter field: encounter_date is non-nullable and defaults to now
  • Discharge Summary: show both date and time of admission

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c0bb3ba) 61.38% compared to head (3dda74e) 61.40%.
Report is 2 commits behind head on master.

Files Patch % Lines
...e/facility/api/serializers/patient_consultation.py 50.00% 1 Missing and 2 partials ⚠️
care/abdm/utils/fhir.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1728      +/-   ##
==========================================
+ Coverage   61.38%   61.40%   +0.01%     
==========================================
  Files         211      211              
  Lines       11595    11595              
  Branches     1660     1658       -2     
==========================================
+ Hits         7118     7120       +2     
+ Misses       4205     4204       -1     
+ Partials      272      271       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few changes

care/facility/models/patient_consultation.py Outdated Show resolved Hide resolved
care/facility/api/serializers/bed.py Outdated Show resolved Hide resolved
care/facility/api/serializers/patient_consultation.py Outdated Show resolved Hide resolved
@nihal467
Copy link
Member

nihal467 commented Dec 6, 2023

LGTM

@sainak sainak added the P2 label Dec 6, 2023
@vigneshhari
Copy link
Member

Resolve Conflicts.

@vigneshhari vigneshhari merged commit 51a11ab into master Dec 20, 2023
11 checks passed
@vigneshhari vigneshhari deleted the encounter-date branch December 20, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admission Date's time is missing from discharge summary
5 participants