Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup dummy data #1758

Merged
merged 2 commits into from
Dec 11, 2023
Merged

cleanup dummy data #1758

merged 2 commits into from
Dec 11, 2023

Conversation

sainak
Copy link
Member

@sainak sainak commented Dec 8, 2023

Proposed Changes

  • load dummy states, districts, local_body and wards from static data
  • remove redundant fixtures
  • remove unnecessary fixtures from facility.json
  • update load_dummy_data command

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@sainak sainak requested review from Ashesh3 and rithviknishad and removed request for Ashesh3 December 8, 2023 13:34
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0869c46) 61.02% compared to head (560b3bd) 61.03%.

Files Patch % Lines
...re/facility/management/commands/load_dummy_data.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1758      +/-   ##
==========================================
+ Coverage   61.02%   61.03%   +0.01%     
==========================================
  Files         211      211              
  Lines       11589    11587       -2     
  Branches     1659     1659              
==========================================
  Hits         7072     7072              
+ Misses       4264     4262       -2     
  Partials      253      253              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gigincg gigincg merged commit 09edf05 into master Dec 11, 2023
10 of 11 checks passed
@gigincg gigincg deleted the sainak/fix/dummy-data branch December 11, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with dummy data / fixtures
4 participants