Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Telemedicine as a rounds type option #1760

Merged
merged 5 commits into from
Dec 19, 2023
Merged

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Dec 9, 2023

Frontend Issue: ohcnetwork/care_fe#6831

Proposed Changes

  • Add Telemedicine as a daily rounds type option

Associated Issue

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add validation to allow create of telemedicine rounds only if related consultation is DC?

image

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c0bb3ba) 61.38% compared to head (5d4259e) 61.40%.
Report is 4 commits behind head on master.

Files Patch % Lines
care/facility/api/serializers/daily_round.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1760      +/-   ##
==========================================
+ Coverage   61.38%   61.40%   +0.01%     
==========================================
  Files         211      211              
  Lines       11595    11596       +1     
  Branches     1660     1661       +1     
==========================================
+ Hits         7118     7120       +2     
+ Misses       4205     4203       -2     
- Partials      272      273       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ashesh3
Copy link
Member Author

Ashesh3 commented Dec 9, 2023

Should we add validation to allow create of telemedicine rounds only if related consultation is DC?

image

The option is already hidden in the frontend, but I do agree it's a best practice to add a validation here to ensure data consistency.

@nihal467
Copy link
Member

@Ashesh3 fix the test

@nihal467
Copy link
Member

LGTM

@nihal467
Copy link
Member

@vigneshhari can you review this priority PR

@vigneshhari
Copy link
Member

Something feels off about the migration, why is it showing that a migration was edited , cc @sainak

@Ashesh3
Copy link
Member Author

Ashesh3 commented Dec 18, 2023

Something feels off about the migration, why is it showing that a migration was edited , cc @sainak

While resolving a merge conflict with the migration, I might have moved one of the previous migrations after this PR's migration 😅 . I've fixed that, should be fine now. could you review?

@vigneshhari vigneshhari merged commit 3063a58 into master Dec 19, 2023
10 of 11 checks passed
@vigneshhari vigneshhari deleted the telemedicine-round branch December 19, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants