-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Import External Result is failing for valid data #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1762 +/- ##
==========================================
+ Coverage 61.02% 61.35% +0.32%
==========================================
Files 211 211
Lines 11589 11589
Branches 1659 1659
==========================================
+ Hits 7072 7110 +38
+ Misses 4264 4207 -57
- Partials 253 272 +19 ☔ View full report in Codecov by Sentry. |
sainak
approved these changes
Dec 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs tests
@sainak done |
sainak
approved these changes
Dec 9, 2023
rithviknishad
approved these changes
Dec 11, 2023
Ashesh3
approved these changes
Dec 11, 2023
khavinshankar
approved these changes
Dec 11, 2023
gigincg
approved these changes
Dec 11, 2023
vigneshhari
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Converted the data type to string
Associated Issue
Fixes #1761
Merge Checklist
/docs
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins