Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Import External Result is failing for valid data #1762

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

Pranshu1902
Copy link
Contributor

Proposed Changes

Converted the data type to string

Associated Issue

Fixes #1761

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@rithviknishad rithviknishad added the P1 High priority; urgent label Dec 9, 2023
Copy link

codecov bot commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0869c46) 61.02% compared to head (8b529d2) 61.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1762      +/-   ##
==========================================
+ Coverage   61.02%   61.35%   +0.32%     
==========================================
  Files         211      211              
  Lines       11589    11589              
  Branches     1659     1659              
==========================================
+ Hits         7072     7110      +38     
+ Misses       4264     4207      -57     
- Partials      253      272      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests

@Pranshu1902
Copy link
Contributor Author

Needs tests

@sainak done

@gigincg gigincg merged commit 48e5468 into coronasafe:master Dec 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority; urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import External Result is failing for valid data as well
7 participants