Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add events module #1784

Merged
merged 10 commits into from
Feb 12, 2024
Merged

add events module #1784

merged 10 commits into from
Feb 12, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Dec 26, 2023

Proposed Changes

  • Brief of changes made.

Associated Issue

  • Link to issue here, explain how the proposed solution will solve the reported issue/ feature request.

Architecture changes

  • Remove this section if not used

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (fcea22e) 61.65% compared to head (3cc000b) 61.40%.
Report is 3 commits behind head on master.

❗ Current head 3cc000b differs from pull request most recent head 8512769. Consider uploading reports for the commit 8512769 to get more accurate results

Files Patch % Lines
...e/facility/management/commands/load_event_types.py 0.00% 20 Missing ⚠️
care/facility/api/viewsets/events.py 74.50% 13 Missing ⚠️
care/facility/events/handler.py 77.58% 10 Missing and 3 partials ⚠️
care/utils/event_utils.py 66.66% 6 Missing and 4 partials ⚠️
care/facility/models/events.py 79.54% 9 Missing ⚠️
care/facility/api/serializers/events.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1784      +/-   ##
==========================================
- Coverage   61.65%   61.40%   -0.26%     
==========================================
  Files         211      214       +3     
  Lines       11721    11730       +9     
  Branches     1664     1686      +22     
==========================================
- Hits         7227     7203      -24     
- Misses       4196     4248      +52     
+ Partials      298      279      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

care/facility/models/events.py Outdated Show resolved Hide resolved
care/facility/events/handler.py Show resolved Hide resolved
care/facility/events/handler.py Outdated Show resolved Hide resolved
care/facility/events/handler.py Outdated Show resolved Hide resolved
@vigneshhari vigneshhari merged commit 33bb1cd into master Feb 12, 2024
8 of 9 checks passed
@vigneshhari vigneshhari deleted the sainak/feat/events-module branch February 12, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants