Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the bridge service registration endpoint #1793

Merged
merged 3 commits into from
Dec 29, 2023

Conversation

khavinshankar
Copy link
Member

Updated the Bridge Service Registration endpoint as the previous one was disabled in production (ABDM's production) environments.

https://devforum.abdm.gov.in/t/bridge-open-api-addupdateservices/6494

Note:

The new endpoint that we are using doesn't work in staging (ABDM's staging). (I have raised this issue in the ABDM forum https://devforum.abdm.gov.in/t/mutiplehrpaddupdateservices-is-returning-empty-json-objects/8685)
image

So I tested the new endpoint directly in production (ABDM's production) and it works perfectly fine.
image

@khavinshankar khavinshankar added bug Something isn't working P1 High priority; urgent ABDM labels Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (5360702) 61.24% compared to head (e6de51b) 61.19%.

Files Patch % Lines
care/abdm/api/viewsets/health_facility.py 12.50% 14 Missing ⚠️
care/abdm/utils/api_call.py 40.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1793      +/-   ##
==========================================
- Coverage   61.24%   61.19%   -0.05%     
==========================================
  Files         208      208              
  Lines       11480    11497      +17     
  Branches     1650     1654       +4     
==========================================
+ Hits         7031     7036       +5     
- Misses       4177     4189      +12     
  Partials      272      272              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gigincg gigincg merged commit 1233794 into master Dec 29, 2023
9 of 11 checks passed
@gigincg gigincg deleted the hfr_service_registration branch December 29, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ABDM bug Something isn't working P1 High priority; urgent reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants