Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for deleting a location #1812

Merged

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Jan 8, 2024

Proposed Changes

Add support to delete an Asset Location

Associated Issue

Partially Fixes #6976

image

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (00eea21) 61.68% compared to head (bcf1410) 61.71%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1812      +/-   ##
==========================================
+ Coverage   61.68%   61.71%   +0.02%     
==========================================
  Files         212      212              
  Lines       11685    11694       +9     
  Branches     1657     1659       +2     
==========================================
+ Hits         7208     7217       +9     
  Misses       4180     4180              
  Partials      297      297              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sainak
Copy link
Member

sainak commented Jan 9, 2024

@Pranshu1902 can you add test cases where beds, assets and patients are linked to a location

@Pranshu1902
Copy link
Contributor Author

@sainak done, could you review it?

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any implementation of where the API rejects for the reasons specified in the issue

image

care/facility/tests/test_asset_location_api.py Outdated Show resolved Hide resolved
Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
@nihal467
Copy link
Member

Functionality LGTM

@Pranshu1902
Copy link
Contributor Author

@vigneshhari could you review this PR

@vigneshhari vigneshhari merged commit 29b1569 into coronasafe:master Feb 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for deleting a location
6 participants