Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix patient discharge_reason filter and add it to export #1818

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Jan 10, 2024

This pull request fixes the patient discharge_reason filter in the patient API viewset and adds it to the export functionality.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (470ce0d) 61.05% compared to head (9e409d6) 61.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1818   +/-   ##
=======================================
  Coverage   61.05%   61.05%           
=======================================
  Files         208      208           
  Lines       11529    11529           
  Branches     1656     1656           
=======================================
  Hits         7039     7039           
  Misses       4218     4218           
  Partials      272      272           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ashesh3 Ashesh3 added the P1 High priority; urgent label Jan 10, 2024
@sainak
Copy link
Member

sainak commented Jan 10, 2024

We can keep the old names

@Ashesh3
Copy link
Member Author

Ashesh3 commented Jan 10, 2024

We can keep the old names

That's alright, We'll switch everything back to discharge_reason after a week of production, in the next stage as planned. Let's just keep it distinct for now to follow along the changes made 😅

@vigneshhari vigneshhari merged commit 2133846 into master Jan 11, 2024
11 checks passed
@vigneshhari vigneshhari deleted the discharge-filter-fix branch January 11, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority; urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants