Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Delete unused Meta ICD11 Diagnosis Table #1831

Merged
merged 4 commits into from
Feb 10, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jan 17, 2024

Proposed Changes

  • Deletes unused MetaICD11Diagnosis model built for analytics previously in favor of ICD11Diagnosis model.

The future is now
image

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@rithviknishad
Copy link
Member Author

Waiting for confirmation from @Ashesh3 as to whether all existing references to the table has been removed from Metabase

@Ashesh3
Copy link
Member

Ashesh3 commented Jan 22, 2024

No Metabase queries are using this table, we can proceed with the deletion.

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5b51a1a) 61.68% compared to head (e46a13b) 61.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1831      +/-   ##
==========================================
- Coverage   61.68%   61.62%   -0.07%     
==========================================
  Files         212      211       -1     
  Lines       11685    11663      -22     
  Branches     1657     1657              
==========================================
- Hits         7208     7187      -21     
+ Misses       4180     4179       -1     
  Partials      297      297              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari vigneshhari merged commit 9575dcc into master Feb 10, 2024
11 checks passed
@vigneshhari vigneshhari deleted the delete-deprecated-meta-icd-11-table branch February 10, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants