-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track Location Uptime #1843
Merged
Merged
Track Location Uptime #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1843 +/- ##
==========================================
- Coverage 61.65% 61.60% -0.06%
==========================================
Files 211 212 +1
Lines 11721 11780 +59
Branches 1664 1674 +10
==========================================
+ Hits 7227 7257 +30
- Misses 4196 4224 +28
- Partials 298 299 +1 ☔ View full report in Codecov by Sentry. |
sainak
requested changes
Feb 8, 2024
sainak
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rithviknishad
approved these changes
Feb 10, 2024
@vigneshhari could you review this once? |
vigneshhari
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new task to periodically check the status of asset locations and record their availability. It also includes changes to the API to support querying the availability records.
Key File Changes
Asset Serializer Modifications (
asset.py
inserializers
andviewsets
):AssetAvailabilityRecord
toAvailabilityRecord
.Migration Script (
0408_availabilityrecord_delete_assetavailabilityrecord_and_more.py
):AssetAvailabilityRecord
toAvailabilityRecord
.Model Changes (
asset.py
inmodels
):AvailabilityRecord
model.AssetAvailabilityRecord
and updates to related model fields.Task Updates (
asset_monitor.py
andlocation_monitor.py
intasks
):AvailabilityRecord
.location_monitor.py
).Minor Adjustments (
__init__.py
intasks
):Summary
The PR aims to improve the tracking system for asset and location availability within the CARE project. The changes suggest a shift towards a more generic
AvailabilityRecord
model that can handle different types of assets and locations, enhancing the system's flexibility and scalability. The migration script ensures a smooth transition from the old model to the new system without data loss.The modifications in serializers, viewsets, and models indicate a thorough update to accommodate these changes, ensuring that the system's API and internal workings remain consistent with the new data structure. Additionally, the updates to the periodic tasks hint at a broader application of these changes, likely impacting how asset and location statuses are monitored and recorded in real time.
These changes reflect a significant improvement in the system's ability to track and report on the operational status of various assets and locations, which is crucial for efficient resource management and operational oversight in the context of the CARE project.
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins