Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom prefix and suffix to hip name #1861

Merged
merged 3 commits into from
Feb 10, 2024
Merged

Add custom prefix and suffix to hip name #1861

merged 3 commits into from
Feb 10, 2024

Conversation

khavinshankar
Copy link
Member

Proposed Changes

  • add postfix and prefix and clean hip name before service registration
  • set register to true if the facility is already associated with the bridge ID

Associated Issue

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (00eea21) 61.68% compared to head (9bada94) 61.65%.
Report is 1 commits behind head on master.

Files Patch % Lines
care/abdm/api/viewsets/health_facility.py 10.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1861      +/-   ##
==========================================
- Coverage   61.68%   61.65%   -0.04%     
==========================================
  Files         212      212              
  Lines       11685    11693       +8     
  Branches     1657     1658       +1     
==========================================
+ Hits         7208     7209       +1     
- Misses       4180     4187       +7     
  Partials      297      297              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sainak sainak changed the title Fixes 1849 Add custom prefix and suffix to hip name Jan 30, 2024
@vigneshhari vigneshhari merged commit 307a7c5 into master Feb 10, 2024
9 of 11 checks passed
@vigneshhari vigneshhari deleted the fix#1849 branch February 10, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with registering health facility as a service
4 participants