Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add django filter for patient review missed #1938

Merged
merged 18 commits into from
Apr 9, 2024

Conversation

jainvedant392
Copy link
Contributor

@jainvedant392 jainvedant392 commented Mar 2, 2024

Proposed Changes

  • Added a custom filter "review_missed", checking whether "review_time" is greater than present data or not.

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need tests

@jainvedant392
Copy link
Contributor Author

Need tests

@rithviknishad , Do I have to do them?

@sainak
Copy link
Member

sainak commented Mar 11, 2024

Need tests

@rithviknishad , Do I have to do them?

yes

@jainvedant392
Copy link
Contributor Author

@sainak Could you please guide me a little on how to write tests for the changes I have made?

@jainvedant392
Copy link
Contributor Author

Hey @sainak, I have added test for the review missed filter, could you please review them?

@jainvedant392
Copy link
Contributor Author

In the test, I am checking inside a loop whether every patient, in the response returned, satisfies the condition for a missed review

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 62.55%. Comparing base (8dee3d9) to head (38b8df4).

❗ Current head 38b8df4 differs from pull request most recent head faddd1e. Consider uploading reports for the commit faddd1e to get more accurate results

Files Patch % Lines
care/facility/api/viewsets/patient.py 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1938      +/-   ##
===========================================
- Coverage    62.60%   62.55%   -0.05%     
===========================================
  Files          223      223              
  Lines        12277    12278       +1     
  Branches      1750     1754       +4     
===========================================
- Hits          7686     7681       -5     
- Misses        4269     4274       +5     
- Partials       322      323       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jainvedant392 jainvedant392 requested a review from a team as a code owner April 4, 2024 10:56
@vigneshhari vigneshhari merged commit da83422 into coronasafe:develop Apr 9, 2024
3 checks passed
@jainvedant392 jainvedant392 deleted the test branch April 10, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants