Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty op number #1954

Merged
merged 2 commits into from Mar 7, 2024
Merged

Allow empty op number #1954

merged 2 commits into from Mar 7, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Mar 7, 2024

This pull request updates the code to allow for an empty op number. It also includes several other changes and fixes related to patient numbers and validation.

TODO:

  • rollback migration on dev instance

@sainak sainak added the P1 High priority; urgent label Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 62.16%. Comparing base (7c85464) to head (facc733).

Files Patch % Lines
...e/facility/api/serializers/patient_consultation.py 50.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1954      +/-   ##
==========================================
+ Coverage   62.14%   62.16%   +0.02%     
==========================================
  Files         221      221              
  Lines       12198    12203       +5     
  Branches     1740     1742       +2     
==========================================
+ Hits         7580     7586       +6     
+ Misses       4310     4308       -2     
- Partials      308      309       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari vigneshhari merged commit 56f2357 into master Mar 7, 2024
10 of 11 checks passed
@vigneshhari vigneshhari deleted the sainak/fix/allow-empty-op-no branch March 7, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority; urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants