Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validations for negative values in inventory and min quanityt #2005

Merged

Conversation

Pranshu1902
Copy link
Contributor

Proposed Changes

  • Add validation for only allowing positive values for Manage Inventory and Minimum required

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.38%. Comparing base (12c645d) to head (a985454).

❗ Current head a985454 differs from pull request most recent head 10f7aae. Consider uploading reports for the commit 10f7aae to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2005      +/-   ##
===========================================
- Coverage    62.45%   62.38%   -0.07%     
===========================================
  Files          221      221              
  Lines        12251    12220      -31     
  Branches      1748     1744       -4     
===========================================
- Hits          7651     7624      -27     
+ Misses        4284     4281       -3     
+ Partials       316      315       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari vigneshhari merged commit ce619ef into coronasafe:develop Apr 3, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage Inventory & Min Quantity Required allows negative values as well
4 participants