Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update devcontainer config #2051

Merged
merged 5 commits into from
Apr 14, 2024
Merged

update devcontainer config #2051

merged 5 commits into from
Apr 14, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Apr 3, 2024

Proposed Changes

  • complete overhaul of devcontainer
  • use standard devcontainer images
  • add node so the same dev container can be used for care_fe
  • expose docker services port for development outside docker
  • add example env for development outside docker
  • add other nice to have features

Architecture changes

  • Remove this section if not used

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.58%. Comparing base (51ce81e) to head (c97a3ba).
Report is 41 commits behind head on develop.

❗ Current head c97a3ba differs from pull request most recent head 6bb522c. Consider uploading reports for the commit 6bb522c to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2051      +/-   ##
===========================================
+ Coverage    62.20%   62.58%   +0.38%     
===========================================
  Files          221      223       +2     
  Lines        12204    12272      +68     
  Branches      1742     1750       +8     
===========================================
+ Hits          7591     7681      +90     
+ Misses        4305     4269      -36     
- Partials       308      322      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari vigneshhari merged commit 40e7aa4 into develop Apr 14, 2024
6 checks passed
@vigneshhari vigneshhari deleted the sainak/fix/devcontainer branch April 14, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants