Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade user skills #2096

Merged
merged 4 commits into from
Apr 22, 2024
Merged

upgrade user skills #2096

merged 4 commits into from
Apr 22, 2024

Conversation

rash-27
Copy link
Contributor

@rash-27 rash-27 commented Apr 16, 2024

Proposed Changes

  • Updated the skills of users list

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@rash-27 rash-27 requested a review from a team as a code owner April 16, 2024 22:16
Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rash-27 you also need to create a custom migration that will add the newly added skills to db if not present, add a condition to skip if the skill table is empty (this would be the case with new instance, so users are expected to load the skill using the load skill command)

@rash-27
Copy link
Contributor Author

rash-27 commented Apr 18, 2024

Ok will add it

@rash-27
Copy link
Contributor Author

rash-27 commented Apr 18, 2024

@sainak is this the required migration , or am I missing something?

@vigneshhari vigneshhari merged commit ca6b558 into coronasafe:develop Apr 22, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants