Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix query bugs while resolving asset hostname #2099

Merged
merged 2 commits into from
Apr 18, 2024
Merged

fix query bugs while resolving asset hostname #2099

merged 2 commits into from
Apr 18, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Apr 18, 2024

Proposed Changes

  • casting the json object was causing it to return with quotes, which was incorrectly filtered out by the queryset, using keytexttransform gives the expected results

Associated Issue

Architecture changes

  • Remove this section if not used

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@sainak sainak requested a review from a team as a code owner April 18, 2024 04:36
@sainak sainak added bug Something isn't working P1 High priority; urgent labels Apr 18, 2024
@vigneshhari vigneshhari merged commit 2c023e1 into develop Apr 18, 2024
3 checks passed
@vigneshhari vigneshhari deleted the sainak/fix/middleware-config-pull branch April 18, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@vigneshhari vigneshhari vigneshhari approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

Assignees
No one assigned
Labels
bug Something isn't working P1 High priority; urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Asset not returned when the same hostname is used in facility and asset
4 participants
@sainak @Ashesh3 @vigneshhari @rithviknishad