added tests for beds endpoints #2104
Open
+130
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khavinshankar
requested changes
May 14, 2024
|
|
||
| response = self.client.get("/api/v1/bed/?bed_type=ISOLATION") | ||
| self.assertEqual(response.status_code, status.HTTP_200_OK) | ||
| self.assertEqual(response.data["results"][0]["name"], self.bed2.name) |
There was a problem hiding this comment.
let's also check the count here
| f"/api/v1/bed/?facility={self.facility2.external_id}" | ||
| ) | ||
| self.assertEqual(response.status_code, status.HTTP_200_OK) | ||
| self.assertEqual(response.data["results"][0]["name"], self.bed3.name) |
There was a problem hiding this comment.
let's also check the count here
rithviknishad
requested changes
May 14, 2024
| self.assertEqual(response.status_code, status.HTTP_200_OK) | ||
| self.assertEqual(response.data["count"], 3) | ||
|
|
||
| response = self.client.get("/api/v1/bed/?bed_type=ISOLATION") |
There was a problem hiding this comment.
Suggested change
| response = self.client.get("/api/v1/bed/?bed_type=ISOLATION") | |
| response = self.client.get("/api/v1/bed/", {"bed_type": "ISOLATION"}) |
Comment on lines
+53
to
+55
| response = self.client.get( | ||
| f"/api/v1/bed/?facility={self.facility2.external_id}" | ||
| ) |
There was a problem hiding this comment.
Suggested change
| response = self.client.get( | |
| f"/api/v1/bed/?facility={self.facility2.external_id}" | |
| ) | |
| response = self.client.get( | |
| f"/api/v1/bed/", | |
| { "facility": self.facility2.external_id }, | |
| ) |
Comment on lines
+59
to
+61
| response = self.client.get( | ||
| f"/api/v1/bed/?location={self.asset_location2.external_id}" | ||
| ) |
There was a problem hiding this comment.
Suggested change
| response = self.client.get( | |
| f"/api/v1/bed/?location={self.asset_location2.external_id}" | |
| ) | |
| response = self.client.get( | |
| "/api/v1/bed/", | |
| { "location": self.asset_location2.external_id }, | |
| ) |
|
@DraKen0009 Can you make the changes? |
|
Yep. I'll update the PR by tonight or tomorrow afternoon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Associated Issue
fixes #2103
Merge Checklist
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins