Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid using distinct in patient list filters #2111

Merged
merged 1 commit into from
Apr 23, 2024
Merged

avoid using distinct in patient list filters #2111

merged 1 commit into from
Apr 23, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Apr 23, 2024

Proposed Changes

  • distinct causes issues with orderby clause so instesd its better to use subuery
  • this fixes the test errors

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@sainak sainak requested a review from a team as a code owner April 23, 2024 12:57
@vigneshhari vigneshhari merged commit eda8931 into develop Apr 23, 2024
9 checks passed
@vigneshhari vigneshhari deleted the sainak/fix/patient-filters branch April 23, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshhari vigneshhari vigneshhari approved these changes

@Ashesh3 Ashesh3 Awaiting requested review from Ashesh3

@rithviknishad rithviknishad Awaiting requested review from rithviknishad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sainak @vigneshhari